Recent posts

#61

Contentious discussions about anything, the world, politics and health topics. / Re: Ukraine total victory ahea...

Last post by José Roca - September 11, 2023, 08:57:01 AM

> [...] because the vaccinated people have a weak immune system.

This is a lie, Dr. Theo.

#62

General Discussion / Re: Why Fruits Have Lost Their...

Last post by Theo Gottwald - September 10, 2023, 10:03:28 PM

I have also heared of this and have some evidence about it.
Just do not want to open this bottle today.
You know i recommend to use Vitamins especially this Winter.
D3, K2 , B12, and C in High Doses.

[and rewrites it in Joses's Style]

#63

AI / ChatGPT / Stable DIffusion / AGI / The state of AI for Programmin...

Last post by Theo Gottwald - September 10, 2023, 06:56:01 PM

In this Post i will just show you an original Input that i gave to GPT-4, and also show you the Output.
While my original Prompt was much shorter, i asked ChatGPT to make me a Prompt for what I was doing.
Currently I let it review old Subprograms for bugs.

Here is the Prompt for that:

Please review and optimize the following PowerBASIC code snippets for text manipulation tasks, often related to handling delimited fields in strings. The operations include copying, reordering, inserting, and removing fields, as well as repairing improperly formatted strings. For each snippet:

Examine the code for readability, maintainability, and performance.
Provide an optimized version, if applicable.
Add annotated comments to the code to make it more understandable.
Explain each change that you make to the original code.
Variable and Macro Information:

Variables are typically prefixed with G_REG (for register variables like R01, R02, etc.), G_T01 (for temporary variables like T01, T02, etc.), and G_S01 (for string variables like S01, S02, etc.).
Macros like G_S01, G_S02, etc., are used for declaring local string variables S01, S02, etc. The number in the macro signifies how many such variables are declared.
Similarly, G_T01 and G_REG are used for declaring temporary and register variables.

My Input code, in my typical programming style.

Code Select Expand

' U01 - Line to repair
' U02 - Delimiter
'
SUB S_Repair_Hochkomma(BYREF U01 AS STRING,BYVAL U02 AS STRING)
G_REG
G_T01
G_S04
R02=TALLY(U01,$Hochkomma)
IF R02=0 THEN GOTO enx
T01=PARSECOUNT(U01,U02)
S02=""
S03=$Hochkomma+$Hochkomma+$Hochkomma
S04=$Hochkomma+$Hochkomma
FOR R01=1 TO T01
    S01=PARSE$(U01,U02,R01)
    R02=TALLY(S01,$Hochkomma)
    REPLACE S03 WITH $Hochkomma IN S01
    R02=TALLY(S01,$Hochkomma)
    IF G_Odd(R02) THEN 'S01+=$Hochkomma
      S01=REMOVE$(S01,ANY $CRLF)
      IF LEFT$(S01,1)=$Hochkomma THEN
          S01+=$Hochkomma
          IF INSTR(S01,S04) THEN S01=REMOVE$(S01,$Hochkomma)
          ITERATE FOR
      ELSE
        S01=REMOVE$(S01,$Hochkomma)
      END IF
    END IF
    S02+=S01+U02
NEXT
  U01=CLIP$(RIGHT S02,1)
 enx:
END SUB 
 

ChatGPT
The subroutine S_Repair_Hochkomma seems to be designed to repair a string (U01) by ensuring that quotation marks ($Hochkomma) are correctly paired and formatted. The string is split by a delimiter (U02), each section is inspected and repaired as needed, and then the string is reassembled.

Here's an optimized version with annotations:

Code Select Expand

' S_Repair_Hochkomma - Repairs a string to ensure correctly paired and formatted quotation marks
' U01 - The string to be repaired (input/output)
' U02 - Delimiter used to split the string
'
SUB S_Repair_Hochkomma(BYREF U01 AS STRING, BYVAL U02 AS STRING)
    G_REG
    G_T01  ' Total number of substrings after splitting
    G_S02  ' Temp string to accumulate results
    LOCAL R02 AS LONG  ' Counter for quotation marks

    ' Count the total number of quotation marks in U01
    R02 = TALLY(U01, $Hochkomma)
   
    ' If no quotation marks are found, exit the subroutine
    IF R02 = 0 THEN GOTO enx

    ' Count the number of substrings when split by U02
    T01 = PARSECOUNT(U01, U02)
   
    ' Initialize temp variables
    S02 = ""
    LOCAL S03 AS STRING: S03 = $Hochkomma + $Hochkomma + $Hochkomma
    LOCAL S04 AS STRING: S04 = $Hochkomma + $Hochkomma

    FOR R01 = 1 TO T01
        LOCAL S01 AS STRING: S01 = PARSE$(U01, U02, R01)
        R02 = TALLY(S01, $Hochkomma)
       
        ' Replace triple quotes with a single quote
        REPLACE S03 WITH $Hochkomma IN S01
       
        ' Count quotation marks again
        R02 = TALLY(S01, $Hochkomma)
       
        ' Check for an odd number of quotes
        IF G_Odd(R02) THEN
            ' Remove new lines
            S01 = REMOVE$(S01, ANY $CRLF)
           
            ' Handle the quote at the beginning
            IF LEFT$(S01, 1) = $Hochkomma THEN
                S01 += $Hochkomma
                IF INSTR(S01, S04) THEN S01 = REMOVE$(S01, $Hochkomma)
                ITERATE FOR
            ELSE
                S01 = REMOVE$(S01, $Hochkomma)
            END IF
        END IF
       
        ' Accumulate results
        S02 += S01 + U02
    NEXT

    ' Remove trailing delimiter
    U01 = CLIP$(RIGHT S02, 1)
   
    enx:
END SUB


Improvements and annotations:

Added comments to describe the purpose of each variable and overall function of the subroutine.
Used LOCAL for variables that are only needed within the loop (S01).
Removed G_S04 as it was not used in the subroutine.
Again, this assumes the presence and correct functioning of other functions and subroutines that are being called, like G_Odd().

Here is another Sample, where GPT4 improved the logic in my code:

Let's start by reviewing the function S_NInstr in your PowerBASIC code.

Original Code, Powerbasic
Copy code

Code Select Expand

FUNCTION S_NInstr(BYREF U01 AS STRING,BYVAL U02 AS STRING,OPT BYVAL U03 AS LONG, BYVAL U04 AS LONG) AS LONG
G_REG
IF U04=0 THEN U04=1
FOR R01=1 TO U03
  R02=INSTR(U04,U01,U02)
  IF R02=0 THEN GOTO enx
  U04=R02+1
NEXT
enx:
FUNCTION=R02
END FUNCTION 

Observations
The function S_NInstr is trying to find the position of the N-th occurrence of a substring (U02) in a main string (U01).
U03 is the N-th occurrence to find, and U04 is the starting position of the search. If U04 is 0, it defaults to 1.
Register variables (R01, R02) are used for loop counters and storing the intermediate result.
The function seems to follow the G_REG convention for declaring register variables (R01, R02).
Optimized and Annotated Code
Let's optimize the function and add comments to make it more readable.

Code Select Expand

' S_NInstr - Finds the N-th occurrence of a substring in a main string.
' U01 - Main string in which to search
' U02 - Substring to search for
' U03 - N-th occurrence to find (optional, defaults to 1)
' U04 - Starting position for the search (optional, defaults to 1)
' Returns: The position of the N-th occurrence of the substring, or 0 if not found
'
FUNCTION S_NInstr(BYREF U01 AS STRING, BYVAL U02 AS STRING, OPT BYVAL U03 AS LONG = 1, OPT BYVAL U04 AS LONG = 1) AS LONG
  ' Declare register variables
  G_REG
 
  ' Validate and initialize U04
  IF U04 <= 0 THEN U04 = 1
 
  ' Search for the N-th occurrence of the substring
  FOR R01 = 1 TO U03
    R02 = INSTR(U04, U01, U02)
   
    ' If the substring is not found, exit the loop
    IF R02 = 0 THEN EXIT FOR
   
    ' Update the starting position for the next search
    U04 = R02 + LEN(U02)
  NEXT
 
  ' Return the position of the N-th occurrence
  FUNCTION = R02
END FUNCTION

Changes and Improvements
Added default values for U03 and U04 in the function signature.
Added comments to explain each part of the function for better readability.
Replaced GOTO statement with EXIT FOR for better readability and maintainability.
Used LEN(U02) when updating U04 to handle substrings of any length correctly.

At that Place GPT4 made a Mistake, he used a Purebasic Feature in the optional variables.
SO i said:

You can not do this in Powerbasic "=1" for optional variables, this only available in Purebasic. Please move this into the code and start over

ChatGPT
I apologize for the oversight. Let's correct that and adjust the code accordingly.

Corrected and Annotated Code

Code Select Expand

' S_NInstr - Finds the N-th occurrence of a substring in a main string.
' U01 - Main string in which to search
' U02 - Substring to search for
' U03 - N-th occurrence to find (optional, defaults to 1 if not provided)
' U04 - Starting position for the search (optional, defaults to 1 if not provided)
' Returns: The position of the N-th occurrence of the substring, or 0 if not found
'
FUNCTION S_NInstr(BYREF U01 AS STRING, BYVAL U02 AS STRING, OPT BYVAL U03 AS LONG, OPT BYVAL U04 AS LONG) AS LONG
  ' Declare register variables
  G_REG
 
  ' Validate and initialize U03 and U04
  IF U03 = 0 THEN U03 = 1
  IF U04 = 0 THEN U04 = 1
 
  ' Search for the N-th occurrence of the substring
  FOR R01 = 1 TO U03
    R02 = INSTR(U04, U01, U02)
   
    ' If the substring is not found, exit the loop
    IF R02 = 0 THEN EXIT FOR
   
    ' Update the starting position for the next search
    U04 = R02 + LEN(U02)
  NEXT
 
  ' Return the position of the N-th occurrence
  FUNCTION = R02
END FUNCTION


Changes and Improvements
Moved the default value assignment for U03 and U04 into the function body to comply with PowerBASIC's limitations.
Retained comments to explain each part of the function for better readability.
Retained the use of EXIT FOR instead of GOTO for better maintainability.
Used LEN(U02) when updating U04 to handle substrings of any length correctly.
Let me know if this updated version meets your requirements.

Now after some time, GPT-4 shows its true face.
That is when he runs into his Token Limit.
He will then destroy the carefully chosen variables from my Script and rewrites it in Joses's Style :-).

So i replied my Prompt:

Please review and optimize the following PowerBASIC code snippets for text manipulation tasks, often related to handling delimited fields in strings. The operations include copying, reordering, inserting, and removing fields, as well as repairing improperly formatted strings. For each snippet:

Examine the code for readability, maintainability, and performance.
Provide an optimized version, if applicable.
Add annotated comments to the code to make it more understandable.
Explain each change that you make to the original code.
Variable and Macro Information:

Variables are typically prefixed with G_REG (for register variables like R01, R02, etc.), G_T01 (for temporary variables like T01, T02, etc.), and G_S01 (for string variables like S01, S02, etc.).
Macros like G_S01, G_S02, etc., are used for declaring local string variables S01, S02, etc. The number in the macro signifies how many such variables are declared.
Similarly, G_T01 and G_REG are used for declaring temporary and register variables.
Please use the two available REGISTER Variable R01 and R02 for the mist often used LONG Variables, and exchange the names if needed.
Here are the code snippets:

Code Select Expand

' U01 - C68
' U02 - $$IND
' U03 - Delimiter ";"
' Gibt nur die angegebenen Spalten zurück
FUNCTION S_Get_Delimited_Fields_from_Text(BYREF U01 AS STRING,BYREF U02 AS STRING,OPT BYVAL U03 AS STRING) AS STRING
  G_REG
  G_S06
  G_T01
  LOCAL AF(),RC() AS STRING
  IF LEN(U01)<1 THEN GOTO enx
  ' Index Liste hier vorbereiten, spart später Zeit
  S01=TRIM$(U02)
  S_Evaluate_Column_List(S01)
  ' Delimiter
  IF LEN(U03) THEN
    S03=TRIM$(U03)
  ELSE
    S03=";"
  END IF
  T01=PARSECOUNT(U01,$CRLF)
  DIM AF(1 TO T01),RC(1 TO T01)
  PARSE C68,RC(),$CRLF
  FOR R01=1 TO T01
      ' Get Line
      S04=RC(R01) 'PARSE$(U01,$CRLF,R01)
      S05=S_Get_Delimited_Fields(S04,S03,S01)
      S_Repair_Hochkomma(S05,S03)
      AF(R01)=S05
  NEXT
  S06=JOIN$(AF(),$CRLF)
  S01=BUILD$($LF,$LF)
  REPLACE S01 WITH $LF IN S06
enx:
FUNCTION=S06
END FUNCTION

ChatGPT
Code Review and Optimization
Readability, Maintainability, and Performance:
The variable names are abbreviated, making it hard to understand the purpose of each variable.
Using GOTO makes the code less readable and maintainable.
Variable names like AF, RC, S01, S03, etc., are not self-explanatory.
The use of $CRLF and $LF could be explained better.
Use of REGISTER for the most commonly used LONG variables is good for performance.
Optimized Version:

Code Select Expand

' Purpose: Returns only the specified columns from a delimited text
' U01 - Text content
' U02 - Index list (e.g., column numbers or names)
' U03 - Delimiter (optional, default is ";")
FUNCTION S_Get_Delimited_Fields_from_Text(BYREF TextContent AS STRING, BYREF IndexList AS STRING, OPT BYVAL Delimiter AS STRING) AS STRING
  ' Local variable declarations
  LOCAL LinesArray(), ParsedArray() AS STRING
  LOCAL PreparedIndex, TrimmedDelimiter, CurrentLine, Result AS STRING
  REGISTER LineCount, LineIndex AS LONG  ' Using REGISTER for the most commonly used LONG variables

  ' Check if TextContent is empty
  IF LEN(TextContent) < 1 THEN EXIT FUNCTION

  ' Prepare the index list to save time later
  PreparedIndex = TRIM$(IndexList)
  S_Evaluate_Column_List(PreparedIndex)

  ' Set the delimiter
  IF LEN(Delimiter) THEN
    TrimmedDelimiter = TRIM$(Delimiter)
  ELSE
    TrimmedDelimiter = ";"
  END IF

  ' Initialize array dimensions
  LineCount = PARSECOUNT(TextContent, $CRLF)
  DIM LinesArray(1 TO LineCount), ParsedArray(1 TO LineCount)
  PARSE TextContent, ParsedArray(), $CRLF

  ' Loop through each line
  FOR LineIndex = 1 TO LineCount
    CurrentLine = ParsedArray(LineIndex)
    CurrentLine = S_Get_Delimited_Fields(CurrentLine, TrimmedDelimiter, PreparedIndex)
    S_Repair_Hochkomma(CurrentLine, TrimmedDelimiter)
    LinesArray(LineIndex) = CurrentLine
  NEXT

  ' Join lines and remove extra line feeds
  Result = JOIN$(LinesArray(), $CRLF)
  PreparedIndex = BUILD$($LF, $LF)
  REPLACE PreparedIndex WITH $LF IN Result

  FUNCTION = Result
END FUNCTION


Changes Made:
Changed variable names to be more descriptive.
Removed GOTO and used EXIT FUNCTION for better readability.
Used REGISTER for the two most frequently used LONG variables: LineCount and LineIndex.
Added comments to explain what each part of the code is doing.
Replaced abbreviated names like S01, S03, etc., with more descriptive names like PreparedIndex, TrimmedDelimiter, etc.
Combined similar operations into single lines where appropriate for brevity and performance.
With these changes, the code should be more readable, maintainable, and possibly even slightly more performant.

#64

General Discussion / The Art of Code

Last post by Charles Pegge - September 10, 2023, 02:53:54 PM

The Art of Code - Dylan Beattie
NDC Conferences
26 feb 2020

#65

General Discussion / Programming’s Greatest Mistake...

Last post by Charles Pegge - September 10, 2023, 12:01:49 PM

A humorous narrative. (beware copious F words at the beginning)

Programming's Greatest Mistakes - Mark Rendle - NDC Copenhagen 2022
NDC Conferences
18 aug 2022

#66

General Discussion / Why Fruits Have Lost Their Vit...

Last post by Charles Pegge - September 10, 2023, 12:11:29 AM

Why Fruits Have Lost Their Vitamins | ENDEVR Documentary
ENDEVR
3 sept 2023

#67

Contentious discussions about anything, the world, politics and health topics. / Re: Ukraine total victory ahea...

Last post by José Roca - September 09, 2023, 11:08:47 PM

I don't understand how you can be so gullible. Don't you see that what Bild says is too good for the Russians to be true.

#68

Contentious discussions about anything, the world, politics and health topics. / Re: Ukraine total victory ahea...

Last post by José Roca - September 09, 2023, 10:27:02 PM

I see. It is an invention of "Bild".

Guterres sent a letter to Putin detailing a proposal to revive the grain deal.

During a briefing on Monday, July 17, Guterres also said that the UN offers Russia an alternative to SWIFT.

"We have created a customized payment mechanism for the Russian Agricultural Bank through JPMorgan outside of SWIFT," he concluded.

Instead of reading the "Bild" tabloid, go to the source: The United Nations.

See: https://unric.org/it/the-secretary-general-press-remarks-on-the-black-sea-initiative-and-memorandum-of-understanding-on-facilitating-exports-of-russian-food-products-and-fertilizers/

Guterres: "I am deeply disappointed that my proposals went unheeded."

#69

Contentious discussions about anything, the world, politics and health topics. / Re: Ukraine total victory ahea...

Last post by José Roca - September 09, 2023, 09:39:00 PM

Where is the letter?

I doubt that the letter proposes that.

This is more like a Russian wish list.

A dead letter.

#70

Contentious discussions about anything, the world, politics and health topics. / Re: Ukraine total victory ahea...

Last post by Theo Gottwald - September 09, 2023, 08:45:39 AM

📝 **Letter from UN Secretary-General Guterres to Russian Foreign Minister Lavrov:**
🔹 **1. Russian state bank may return to Swift**
🔹 **2. Russian ships will be insured against Ukraine attacks**
🔹 **3. Russia will get back seized money**
🔹 **4. Russian ships may dock again in Germany and the EU**

👇 **They are groveling in the dust.**

https://www.focus.de/politik/ausland/ukraine-krise/brisanter-brief-aufgetaucht-zu-gut-um-wahr-zu-sein-fuer-getreide-deal-wirft-sich-die-un-putin-an-den-hals_id_204046939.html